-
Notifications
You must be signed in to change notification settings - Fork 23
CI Try caching precompilation #1530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
.github/workflows/CI.yml
Outdated
version: ["1.10", "1.11"] | ||
os: [ubuntu-24.04, ubuntu-22.04-arm, macOS-latest] | ||
runtime: ["PJRT", "IFRT"] | ||
assertions: [false, true] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what is worth, I personally like expanding lists in the one-per-line format, like in
Reactant.jl/.github/workflows/CI.yml
Lines 67 to 87 in eca8191
- "1.10" | |
- "1.11" | |
# - 'nightly' | |
os: | |
- ubuntu-24.04 | |
# `ubuntu-22.04-arm` is considered more stable than `ubuntu-24.04-arm`: | |
# <https://github.com/orgs/community/discussions/148648#discussioncomment-12099554>. | |
- ubuntu-22.04-arm | |
# Disable `macOS-13` until | |
# <https://github.com/EnzymeAD/Reactant.jl/issues/867> is resolved. | |
# - macOS-13 | |
- macOS-latest | |
test_group: | |
- core | |
- neural_networks | |
- integration | |
runtime: | |
- "PJRT" | |
- "IFRT" | |
assertions: | |
- false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll take this into account.
I'm still mainly messing around with things for now.
Do you think it makes sense to have a cache warmup step with cache keys independent of jobs and testgroup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works, it can make sense.
packages are still being precompiled in the test step. I'm looking for a culprit, this seems suspicious:
|
You may want to drastically reduce the matrix (ideally to a single element) while you investigate how to make this work, otherwise you'll waste loads of resources and everybody's time. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
I'm not yet sure this does anything. But if this would work, we could split the tests in many more separate jobs.